Repository navigation
AVRO-4358: [C] Match enum symbols by name in schema resolution - #4033
Open
fabiocfabini wants to merge 1 commit into
Open
fabiocfabini wants to merge 1 commit into
fabiocfabini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Schema resolution in the C SDK (reagrding enums) copied the writer's enum index into the reader's value, so reordered symbols were read as the wrong symbol and missing symbols from the reader produced out-of-range values. This pull request matches enum symbols by name and fails when reading a symbol the reader doesn't have.
Verifying this change
This change added tests and can be verified as follows:
test_avro_4358, that checks the enum schema resolution works even with different order in enum symbols. Also checks for failure when reading a symbol the reader does not have../build.sh clean testpasses inlang/cand valgrind checks.Documentation