Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a signed integer overflow / denial of service in the Apache Avro C SDK's array and map value readers.
Details
In
read_array_value()andread_map_value()(lang/c/src/value-read.c), a negativeblock_countfrom the wire is negated withblock_count * -1. Whenblock_count == INT64_MIN, the negation is undefined behavior; in practice the value stays negative (or wraps), and the subsequentwhile (block_count != 0)loop iterates ~2^63 times, hanging the process on just 11 bytes of input (a trivial remote DoS).The patch rejects
INT64_MINexplicitly withavro_set_error("Invalid array block count")/avro_set_error("Invalid map block count")and returnsEINVAL, mirroring how other invalid encodings are handled.Testing
block_count = INT64_MINhangs the process; after the fix it returnsEINVALimmediately.AI tool use disclosure: AI was used in part for code audit and patch drafting.