Skip to content

pass --add-opens to Spark PVR test JVM on Java 21#39278

Merged
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:fix/spark-pvr-java21-add-opens
Jul 10, 2026
Merged

pass --add-opens to Spark PVR test JVM on Java 21#39278
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:fix/spark-pvr-java21-add-opens

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Fixes: #34207

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim marked this pull request as ready for review July 10, 2026 13:56
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Spark Job Server Gradle configuration to include necessary JVM arguments for the Portable Runner test tasks. This change ensures that the SparkJobServerDriver, when running in-process during tests, receives the required configuration to support Java 21 environments.

Highlights

  • JVM Configuration: Updated the Spark Job Server Gradle configuration to pass JVM arguments to the Portable Runner test tasks.
  • Test Infrastructure: Modified the trigger file for the Spark 3 Streaming PVR post-commit test suite to ensure updated configurations are applied.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request triggers a post-commit test suite and updates the Spark job server Gradle configuration to append JVM arguments to several portable runner tasks. The reviewer recommends using tasks.matching and configureEach instead of tasks.named to prevent potential UnknownTaskException errors during the configuration phase if any of the specified tasks are not registered.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +284 to +288
['validatesPortableRunnerDocker', 'validatesPortableRunnerBatch', 'validatesPortableRunnerStreaming'].each { taskName ->
tasks.named(taskName) {
jvmArgs += sparkJobServerJvmArgs()
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using tasks.named(taskName) will throw an UnknownTaskException during Gradle's configuration phase if any of these tasks are not registered (for example, if certain plugins are conditionally applied or if the tasks are defined in a different order/subproject).

Using tasks.matching { ... }.configureEach { ... } is safer and more robust as it supports configuration avoidance and will not fail if a task is not present.

tasks.matching { it.name in ['validatesPortableRunnerDocker', 'validatesPortableRunnerBatch', 'validatesPortableRunnerStreaming'] }.configureEach {
  jvmArgs += sparkJobServerJvmArgs()
}

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto Amar3tto requested a review from Abacn July 10, 2026 16:38

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit 2c92949 into apache:master Jul 10, 2026
22 of 23 checks passed
@aIbrahiim aIbrahiim deleted the fix/spark-pvr-java21-add-opens branch July 10, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java PVR Spark3 Streaming job is flaky

2 participants