Conversation
8abe13b to
500e9b7
Compare
7522449 to
acbbe46
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40286 +/- ##
============================================
- Coverage 56.14% 55.12% -1.03%
+ Complexity 2288 1722 -566
============================================
Files 1121 1076 -45
Lines 177152 172005 -5147
Branches 1488 1262 -226
============================================
- Hits 99467 94822 -4645
+ Misses 75161 74907 -254
+ Partials 2524 2276 -248
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
* Fix dataset leak in `BigqueryClient.deleteDataset` when a test dataset contains >50 tables (e.g. `StorageApiSinkCreateIfNeededIT` due to response page truncation * Use a unified prefix for integration tests to avoid temp dataset
acbbe46 to
5078f10
Compare
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| private MaxPerKeyExamplesIT.MaxPerKeyExamplesOptions options; | ||
| private final String timestamp = Long.toString(System.currentTimeMillis()); | ||
| private final String outputDatasetId = "max_per_key_examples" + timestamp; | ||
| private final String outputDatasetId = "beam_temp_dataset_maxperkey_" + timestamp; |
There was a problem hiding this comment.
Can we put the prefix into a constant somewhere and refer that in this test and the ones below? Just like what you did for Python.
Fix dataset leak in
BigqueryClient.deleteDatasetwhen a test dataset contains >50 tables (e.g.StorageApiSinkCreateIfNeededITdue to response page truncationUse a unified prefix for integration tests to avoid temp dataset
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.