[Python] Validate FileBasedSink num_shards type - #40331
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25860
FileBasedSinkcurrently accepts a side input fornum_shards, then fails later while processing the pipeline.This validates
num_shardsin the constructor and raises a clearTypeErrorwhen it is not anint. The regression test coversAsSingleton.Before: the constructor accepts
AsSingletonasnum_shards.After: the constructor raises
TypeError: num_shards must be an int.Tests:
python -m unittest -q apache_beam.io.filebasedsink_test— 15 passedpython -m unittest -q apache_beam.io.textio_test— 117 passed