[CALCITE-7726] Improve identifier validation on MemberExpression and ParameterExpression - #5189
Merged
Merged
Conversation
rubenada
commented
Aug 18, 2026
| String tmpName = result.accumulator().isEmpty() | ||
| ? "ar" | ||
| : (result.accumulator().get(0) + "$Res"); | ||
| String tmpName = result.accumulator().isEmpty() ? "ar" : "acc$Res"; |
Contributor
Author
There was a problem hiding this comment.
This was actually a latent bug unveiled by this patch.
For instance TpchTests would fail now on the new checkArgument with "field name should be a valid java identifier" since the old code could include a dot on the identifier (which is incorrect).
The problem was (by chance) hidden because Janino code generator inlined the expression directly, without actually using the problematic identifier; but the bug was there, latent.
mihaibudiu
requested changes
Aug 19, 2026
mihaibudiu
approved these changes
Aug 19, 2026
rubenada
added
the
LGTM-will-merge-soon
…ParameterExpression
|
Contributor
Author
|
Thanks @mihaibudiu for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7726
Changes Proposed
Improve identifier validation on MemberExpression and ParameterExpression. Fail early with a meaningful exception if a wrong identifier is detected.