Added vddk support in vmware to kvm migrations

[harikrishna-patnala]

Description

This PR introduces the VDDK implementation as part of VMware to KVM migration which reduces the migration time by half when compared to the existing implementation with exportOVF

Solution: Introduce VDDK configuration at both the host agent level and per-API-call level, wired through the migration execution pipeline on the KVM host.

---

Key Capabilities

Capability	Detail
Host-level config	Four new agent.properties keys configure VDDK defaults per KVM host
API-level overrides	Callers can pass VDDK settings via importVm details, overriding host defaults
Secure password handling	vCenter password written to a temp file, passed via -ip or --password-file based on virt-v2v version, and deleted immediately after use
Auto-thumbprint fetch	If no thumbprint is configured, it is automatically retrieved from vCenter via openssl s_client

---

Configuration Keys

libguestfs.backend   # LIBGUESTFS backend (default: direct)
vddk.lib.dir         # Path to VDDK library directory
vddk.transports      # Transport preference, e.g. nbd:nbdssl
vddk.thumbprint      # vCenter SHA1 thumbprint (auto-fetched if unset)

---

Precedence

API details  >  agent.properties

---

Doc PR: apache/cloudstack-documentation#640

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 32.74725% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.62%. Comparing base (ae455ee) to head (e88c652).
⚠️ Report is 4 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...ervisor/kvm/resource/LibvirtComputingResource.java	4.67%	102 Missing ⚠️
.../wrapper/LibvirtConvertInstanceCommandWrapper.java	47.72%	82 Missing and 10 partials ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	47.05%	24 Missing and 21 partials ⚠️
...va/com/cloud/agent/api/ConvertInstanceCommand.java	0.00%	24 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java	0.00%	17 Missing ⚠️
...m/cloud/agent/api/CheckConvertInstanceCommand.java	29.41%	12 Missing ⚠️
.../java/com/cloud/agent/api/to/RemoteInstanceTO.java	23.07%	10 Missing ⚠️
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java	0.00%	3 Missing ⚠️
...per/LibvirtCheckConvertInstanceCommandWrapper.java	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12970      +/-   ##
============================================
+ Coverage     17.60%   17.62%   +0.01%     
- Complexity    15688    15711      +23     
============================================
  Files          5919     5919              
  Lines        532005   532451     +446     
  Branches      65060    65138      +78     
============================================
+ Hits          93683    93822     +139     
- Misses       427755   428038     +283     
- Partials      10567    10591      +24     

Flag	Coverage Δ
uitests	3.69% <ø> (-0.01%)	⬇️
unittests	18.69% <32.74%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17380

[harikrishna-patnala]

@blueorangutan package

[sureshanaparti]

should keep other possible options in the comment (other than direct) ?

[sureshanaparti]

if direct is the only option supported for vddk, can remove this config?

[harikrishna-patnala]

@blueorangutan package

[harikrishna-patnala]

@sureshanaparti thanks for all the reviews, I've addressed them

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17479

[sureshanaparti]

code lgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.