Skip to content

Netris: Improvements and fixes to the Netris plugin#13591

Draft
Pearl1594 wants to merge 9 commits into
4.22from
netris-improvements
Draft

Netris: Improvements and fixes to the Netris plugin#13591
Pearl1594 wants to merge 9 commits into
4.22from
netris-improvements

Fix VRRP gateway IP conflict on redundant VPC routers with external n…

81b5274
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 24, 2026 in 8m 55s

Quality Gate failed

Failed conditions
4.6% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 210 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-ap&open=AZ9Mrp1MEhDWL3Zjx-ap&pullRequest=13591

Check warning on line 138 in server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp8rEhDWL3Zjx-bB&open=AZ9Mrp8rEhDWL3Zjx-bB&pullRequest=13591

Check warning on line 221 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-aq&open=AZ9Mrp1MEhDWL3Zjx-aq&pullRequest=13591

Check warning on line 222 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-ar&open=AZ9Mrp1MEhDWL3Zjx-ar&pullRequest=13591

Check warning on line 233 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-au&open=AZ9Mrp1MEhDWL3Zjx-au&pullRequest=13591

Check warning on line 99 in api/src/main/java/com/cloud/network/netris/NetrisService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 11 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp08EhDWL3Zjx-am&open=AZ9Mrp08EhDWL3Zjx-am&pullRequest=13591

Check warning on line 462 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp15EhDWL3Zjx-a3&open=AZ9Mrp15EhDWL3Zjx-a3&pullRequest=13591

Check warning on line 532 in server/src/main/java/com/cloud/network/guru/GuestNetworkGuru.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp6lEhDWL3Zjx-a_&open=AZ9Mrp6lEhDWL3Zjx-a_&pullRequest=13591

Check failure on line 74 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisPublicNetworkGuru.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1gEhDWL3Zjx-a2&open=AZ9Mrp1gEhDWL3Zjx-a2&pullRequest=13591

Check warning on line 115 in api/src/main/java/com/cloud/network/netris/NetrisService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 9 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp08EhDWL3Zjx-an&open=AZ9Mrp08EhDWL3Zjx-an&pullRequest=13591

Check warning on line 547 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.cloud.exception.ResourceUnavailableException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp46EhDWL3Zjx-a-&open=AZ9Mrp46EhDWL3Zjx-a-&pullRequest=13591

Check warning on line 610 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp46EhDWL3Zjx-a9&open=AZ9Mrp46EhDWL3Zjx-a9&pullRequest=13591

Check warning on line 284 in api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change "Object" to the type handled by the Collection. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9MrpxIEhDWL3Zjx-al&open=AZ9MrpxIEhDWL3Zjx-al&pullRequest=13591

Check warning on line 223 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-as&open=AZ9Mrp1MEhDWL3Zjx-as&pullRequest=13591

Check failure on line 1220 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 40 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp15EhDWL3Zjx-a4&open=AZ9Mrp15EhDWL3Zjx-a4&pullRequest=13591

Check warning on line 247 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-a0&open=AZ9Mrp1MEhDWL3Zjx-a0&pullRequest=13591

Check warning on line 383 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move the array designators [] to the type. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp2gEhDWL3Zjx-a7&open=AZ9Mrp2gEhDWL3Zjx-a7&pullRequest=13591

Check warning on line 139 in server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vpcOfferingServiceMapDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp8rEhDWL3Zjx-bA&open=AZ9Mrp8rEhDWL3Zjx-bA&pullRequest=13591

Check warning on line 227 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-at&open=AZ9Mrp1MEhDWL3Zjx-at&pullRequest=13591

Check warning on line 235 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-aw&open=AZ9Mrp1MEhDWL3Zjx-aw&pullRequest=13591

Check warning on line 562 in plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp46EhDWL3Zjx-a8&open=AZ9Mrp46EhDWL3Zjx-a8&pullRequest=13591

Check failure on line 1471 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisApiClientImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp15EhDWL3Zjx-a5&open=AZ9Mrp15EhDWL3Zjx-a5&pullRequest=13591

Check failure on line 366 in plugins/network-elements/netris/src/main/java/org/apache/cloudstack/service/NetrisElement.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to not always return the same value. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp2PEhDWL3Zjx-a6&open=AZ9Mrp2PEhDWL3Zjx-a6&pullRequest=13591

Check warning on line 239 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-ax&open=AZ9Mrp1MEhDWL3Zjx-ax&pullRequest=13591

Check warning on line 246 in plugins/network-elements/netris/src/test/java/org/apache/cloudstack/service/NetrisGuestNetworkGuruTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9Mrp1MEhDWL3Zjx-az&open=AZ9Mrp1MEhDWL3Zjx-az&pullRequest=13591
View more details on SonarQubeCloud