Skip to content

Reject trailing separators in PointConverter#423

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:pointconverter-trailing-separator
Jul 21, 2026
Merged

Reject trailing separators in PointConverter#423
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:pointconverter-trailing-separator

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

PointConverter.convertToType splits the inner coordinate string with POINT_SPLIT.split(coordinates), and String.split with the default limit drops trailing empty tokens. A trailing separator after the two coordinates is swallowed, so (100,200,) and (100,200,,) parse to Point(100,200). That is inconsistent with (100,), which is already rejected because it yields a single token.

Pass -1 as the split limit so trailing empties are kept and the existing xy.length != 2 check rejects the malformed input. Keeping the bound in the converter means every caller gets the same validation, and valid (x,y) forms are unchanged. Found while auditing the awt converters alongside ColorConverter.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title reject trailing separators in PointConverter Reject trailing separators in PointConverter Jul 21, 2026
@garydgregory

Copy link
Copy Markdown
Member

@rootvector2
Please see #419 (comment)

@garydgregory
garydgregory merged commit d1d6214 into apache:master Jul 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants