Reject trailing separators in PointConverter#423
Merged
garydgregory merged 1 commit intoJul 21, 2026
Conversation
Member
|
@rootvector2 |
garydgregory
added a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PointConverter.convertToTypesplits the inner coordinate string withPOINT_SPLIT.split(coordinates), andString.splitwith the default limit drops trailing empty tokens. A trailing separator after the two coordinates is swallowed, so(100,200,)and(100,200,,)parse toPoint(100,200). That is inconsistent with(100,), which is already rejected because it yields a single token.Pass
-1as the split limit so trailing empties are kept and the existingxy.length != 2check rejects the malformed input. Keeping the bound in the converter means every caller gets the same validation, and valid(x,y)forms are unchanged. Found while auditing the awt converters alongsideColorConverter.mvn; that'smvnon the command line by itself.