Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ public DoubleLocaleConverter(final Object defaultValue, final Locale locale, fin
@Override
protected Object parse(final Object value, final String pattern) throws ParseException {
final Number result = (Number) super.parse(value, pattern);
if (result instanceof Long) {
return Double.valueOf(result.doubleValue());
if (result == null || result instanceof Double) {
return result;
}
return result;
return Double.valueOf(result.doubleValue());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ public void tearDown() {
super.tearDown();
}

/**
* Passing a non-Double Number directly (e.g. Integer) must return a Double, not fail the conversion.
*/
public void testConvertFromNonDoubleNumber() {

converter = new DoubleLocaleConverter();

assertEquals(Double.valueOf(42.0), converter.convert(Double.class, Integer.valueOf(42), null));
assertEquals(Double.valueOf(3.14f), converter.convert(Double.class, Float.valueOf(3.14f), null));
assertEquals(Double.valueOf(100L), converter.convert(Double.class, Long.valueOf(100L), null));

}

/**
* Test Converter() constructor
*
Expand Down
Loading