synchronize missing mutators in SynchronizedDescriptiveStatistics#327
Open
dxbjavid wants to merge 1 commit into
Open
synchronize missing mutators in SynchronizedDescriptiveStatistics#327dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SynchronizedDescriptiveStatistics promises that every state-touching method is atomic on the instance, but removeMostRecentValue and replaceMostRecentValue are not overridden, so they mutate the shared backing array with no lock held. A thread calling either of them while another thread is inside a synchronised method like addValue or clear can therefore corrupt the underlying ResizableDoubleArray or trip an ArrayIndexOutOfBoundsException. I have overridden both to delegate under the instance monitor as the sibling mutators already do, and added a test that the calls block while the lock is held (it fails on master).