feat: Add Protobuf support for Explain node#21994
Open
danielhumanmod wants to merge 2 commits intoapache:mainfrom
Open
feat: Add Protobuf support for Explain node#21994danielhumanmod wants to merge 2 commits intoapache:mainfrom
danielhumanmod wants to merge 2 commits intoapache:mainfrom
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Jefffrey
reviewed
May 5, 2026
| into_logical_plan!(explain.input, ctx, extension_codec)?; | ||
| let pb_format = protobuf::ExplainFormat::try_from(explain.format) | ||
| .map_err(|_| { | ||
| internal_datafusion_err!( |
Contributor
There was a problem hiding this comment.
We probably should format the error like so:
datafusion/datafusion/proto/src/logical_plan/mod.rs
Lines 835 to 841 in 7d107f0
- Using proto error variant, and also including the invalid format for visibility
Contributor
Author
There was a problem hiding this comment.
good catch, fixed in the latest commit, thanks!
Jefffrey
approved these changes
May 5, 2026
milenkovicm
approved these changes
May 5, 2026
Contributor
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @danielhumanmod and @Jefffrey for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
EXPLAIN FORMAT TREEis supported in logical plans, but protobuf serialization did not preserve the explain format.In Datafusion Ballista, we need the format field to generate corresponding distributed plan.
apache/datafusion-ballista#1627 (comment)
What changes are included in this PR?
ExplainFormatto protobuf common definitions.formatfield to protobufExplainNode.Are these changes tested?
Yes, we add a roundtrip test for
EXPLAIN FORMAT TREE.Are there any user-facing changes?
No