fix: parenthesize nested expression display names#23356
Open
goutamadwant wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Expression-derived display names could omit required parentheses for nested binary expressions. For example,
(1 + 2) * 3could be displayed as1 + 2 * 3, which changes how the expression reads.Unary expressions with binary children had the same ambiguity, such as
NOT a = band unary negative over a binary expression.What changes are included in this PR?
SchemaDisplay.SqlDisplay.NOTand unary negative expressions.(1 + 2) * 3, unary negative, andNOTwith binary children.Are these changes tested?
cargo test -p datafusion-expr format_nested_binary_exprs_with_parenthesescargo fmt --allcargo test -p datafusion-exprcargo test -p datafusion-optimizercargo clippy -p datafusion-expr -p datafusion-optimizer --all-targets --all-features -- -D warningsgit diff --checkAre there any user-facing changes?
Yes. Expression-derived column names and SQL-like expression display output now include parentheses when needed to preserve the intended expression structure.