fix(optimizer): Take full expression nullability into account for join key nullability - #25029
Draft
AdamGS wants to merge 5 commits into
Draft
fix(optimizer): Take full expression nullability into account for join key nullability#25029AdamGS wants to merge 5 commits into
AdamGS wants to merge 5 commits into
Conversation
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25029 +/- ##
==========================================
- Coverage 81.72% 81.71% -0.01%
==========================================
Files 1127 1127
Lines 416237 416254 +17
Branches 416237 416254 +17
==========================================
+ Hits 340156 340157 +1
- Misses 56092 56104 +12
- Partials 19989 19993 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AdamGS
marked this pull request as draft
September 7, 2026 23:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
NOT INcan return incorrect results when expressions such asNULLIFproduce NULL from non-nullable inputs. Anti joins can retain rows that should be excluded, while mark joins lose SQL UNKNOWN.Nullable correlation expressions can also unnecessarily enable null-aware
execution when both membership values are non-nullable.
What changes are included in this PR?
Determine null-awareness from the full outer membership expression and projected inner value, using their respective input schemas. Correlation predicates do not contribute to membership nullability.
What is the testing strategy for this PR?
Added unit tests and SLT regressions tests that now pass
Are there any user-facing changes?
Some queries are now correct