refactor(req): consolidate fallible construction in builders - #223
Open
Xuanwo wants to merge 3 commits into
Open
refactor(req): consolidate fallible construction in builders#223Xuanwo wants to merge 3 commits into
Xuanwo wants to merge 3 commits into
Conversation
Xuanwo
marked this pull request as ready for review
August 25, 2026 10:19
…lidation # Conflicts: # datasketches/src/req/sketch.rs # datasketches/src/req/union.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REQ construction currently exposes overlapping fallible paths through
try_newand builder configuration, which duplicates validation and makes builder chaining inconsistent.Make
ReqSketchBuilder::buildthe sole fallible construction boundary, add the equivalentReqUnionBuilder, remove the unreleasedtry_newAPIs, and route deserialization and internal construction through the builders.