refactor(req): clarify value comparison contract - #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReqValue::total_cmptoReqValue::compareand keep the trait contract implementation-neutralReqValuetypes explicitly so each ordering and wire-codec mapping is visible without a macrof32andf64numerically withpartial_cmp(...).unwrap(), reject NaN split points, and preserve numeric equality for signed zerosRationale
REQ already skips NaN updates and rejects NaN query and deserialized values, so its internal comparator does not need to define an ordering for NaN. For accepted floating-point values,
partial_cmp(...).unwrap()matches the Java and C++ numeric comparison behavior, including treating signed zeros as equal, and fails immediately if the NaN invariant is violated.The six built-in primitive implementations are small and stable enough to keep explicit. They reuse the existing codec error adapter but do not introduce another helper abstraction. The earlier
common::floatextraction and canonical-hash refactor have been removed; canonical floating-point hashing remains unchanged.No changelog entry is added because REQ is still unreleased.
Testing
cargo x checkcargo x testcargo x lint