refactor: align internal symbol visibility - #245
Merged
Conversation
Let private module boundaries control shared implementation items, while retaining restricted visibility where re-exported public types or modules require it. Document the convention and remove same-module visibility drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub(super)orpub(crate)on each symbolthetacommonmodule require a real API boundaryCONTRIBUTING.mdThe audit reduces
pub(super)occurrences from 143 to 31 andpub(crate)occurrences from 20 to 13. The remaining restricted items all protect externally reachable types or modules.Public API
No public API or behavior changes are intended. The all-feature rustdoc public path set is unchanged, and patch-level
cargo-semver-checksreports no required version update.No changelog entry is needed because this is an internal refactor with no user-visible behavior change.
Testing
cargo x checkcargo x testcargo x lintcargo +stable semver-checks check-release --baseline-rev origin/main --package datasketches --all-features --release-type patch(223 checks passed)