[fix](regression) Fix agg_sync_mv data path#65538
Draft
shuke987 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
Reviewed PR #65538. I did not find a reportable issue.
Checkpoint conclusions:
- Goal/test proof: The patch fixes the second stream load in
agg_sync_mv.groovyso it uses the p1 aggregate suite database and the aggregate data file path. Static framework inspection shows those are the correct targets. - Scope/focusedness: The change is narrowly limited to the broken regression suite stream-load target.
- Concurrency/lifecycle/config/persistence/protocol: Not applicable; this is a test-only path change.
- Parallel paths: The p0 aggregate suite intentionally uses a different parent data-file/database layout; the p1 nested aggregate suite should use
regression_test_nereids_syntax_p1_mv_aggregateand localagg_mv_test.dat. - Test coverage/results: Existing
.outcoverage includes the finalmap_aggblock, and the data has no conflicting duplicate key/value pairs after the second load and repeated self-inserts. I did not run the regression test because the review prompt forbids builds/test execution in this runner. - User focus: No additional user-provided review focus.
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #65133, #65336
Problem Summary:
The second
streamLoadinnereids_syntax_p1/mv/aggregate/agg_sync_mv.groovystill uses the database and data-file path from before the case was moved into theaggregatedirectory.The stale
../agg_mv_test.datpath does not exist. The stream load therefore returns no response, and the regression framework later reports the misleadingText must not be null or emptyerror while parsing it.Align the second load with the working initial load by using database
regression_test_nereids_syntax_p1_mv_aggregateand fileagg_mv_test.dat.Release note
None
Check List (For Author)
Test
git diff --checkpasses, the corrected data file exists, and the stale parent path does not.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)