Skip to content

[test](regression) Apply publish debug point to all FEs#65556

Draft
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:codex/fix-insert-visible-timeout-all-fes
Draft

[test](regression) Apply publish debug point to all FEs#65556
shuke987 wants to merge 1 commit into
apache:masterfrom
shuke987:codex/fix-insert-visible-timeout-all-fes

Conversation

@shuke987

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: N/A

Related PR: #65340

Problem Summary:

test_insert_visible_timeout_return_mode enables PublishVersionDaemon.stop_publish to exercise the committed and error return modes after the visible wait times out.

The case currently adds the debug point only to the FE HTTP endpoint configured for the regression runner. In a multi-FE dynamic pipeline, that endpoint can belong to a follower FE, while PublishVersionDaemon runs only on the master FE. Publishing then continues normally and the expected timeout error is not returned.

Enable and disable the debug point on all FEs so the master is covered regardless of which FE serves the runner. The existing try/finally cleanup remains symmetric.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
      • mvn -f regression-test/framework/pom.xml -DskipTests package
      • Compiled the target Groovy suite with org.codehaus.groovy.tools.FileSystemCompiler
      • git diff --check
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No. This is a regression-case stabilization and does not change product behavior.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: N/A

Related PR: apache#65340

Problem Summary: The insert visible-timeout case enabled PublishVersionDaemon.stop_publish only on the FE HTTP endpoint configured for the regression runner. Dynamic pipelines can connect the runner to a follower FE, while PublishVersionDaemon runs only on the master FE, so the debug point may not block publishing and the expected timeout is not returned. Apply and remove the debug point on all FEs so the master is always covered and cleanup remains symmetric.

### Release note

None

### Check List (For Author)

- Test: Manual test
    - Built the regression-test framework with Maven.
    - Compiled the target Groovy suite with FileSystemCompiler.
    - Ran git diff --check.
- Behavior changed: No. Test-only stabilization.
- Does this need documentation: No.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Collaborator Author

/review

@shuke987

Copy link
Copy Markdown
Collaborator Author

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 20th, 2026 12:23 AM.
Workflow run: https://github.com/apache/doris/actions/runs/29253797581

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants