Repository navigation
[branch-4.1][fix](regression) Support forced replica golden in show create case - #65673
Merged
yiguolei merged 1 commit intoJul 16, 2026
Conversation
Issue Number: None
Related PR: None
Problem Summary: The SHOW CREATE TABLE case always expected one replica even when test environments force OLAP tables to three replicas. Select the full golden matching the effective force replica configuration while preserving the existing one-replica baseline.
None
- Test: Regression test
- test_show_create_table_and_views_nereids with force replica 3
- Behavior changed: No
- Does this need documentation: No
(cherry picked from commit 051a02b)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Static review completed for PR #65673. I did not find a blocking issue.
Checked:
- The Groovy suite computes the effective replica count from
force_olap_table_replication_allocationbeforeforce_olap_table_replication_num, matching the FE forced-replica precedence. - The dynamic
quickRunTesttags line up with the new replica-1 and replica-3 golden blocks, and the regression output iterator skips unused alternate blocks safely. SHOW CREATE TABLE, rollup, andCREATE TABLE LIKEpaths continue to serialize the default-tag replica allocation as expected for the intended branch-4.1 forced-replica case.- The changed-file sweep covered both changed files. Existing inline comments: none. Additional user focus: none.
Validation: static review plus git diff --check on the prompted range passed. I did not run the regression suite in this runner. The main review, two normal subagents, and the risk-focused subagent all converged with NO_NEW_VALUABLE_FINDINGS, so no inline comments are proposed.
Contributor
|
skip buildall |
yiguolei
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #65543
Problem Summary:
Backport the forced-replica-aware SHOW CREATE golden selection to branch-4.1. The branch-4.1 P0 environment forces OLAP tables to three replicas, while this case only had the one-replica golden. The master result file could not be cherry-picked directly because branch-4.1 does not emit
binlog.format, so this backport preserves the complete branch-4.1 baseline and adds matching replica-1/replica-3 result blocks.Release note
None
Check List (For Author)
Test
replication_allocation.git diff --checkpassed.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)