Skip to content

[branch-4.1][fix](regression) Support forced replica golden in show create case - #65673

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
shuke987:codex/backport-show-create-replica-branch41
Jul 16, 2026
Merged

yiguolei merged 1 commit into
apache:branch-4.1from
shuke987:codex/backport-show-create-replica-branch41

Conversation

@shuke987

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: #65543

Problem Summary:

Backport the forced-replica-aware SHOW CREATE golden selection to branch-4.1. The branch-4.1 P0 environment forces OLAP tables to three replicas, while this case only had the one-replica golden. The master result file could not be cherry-picked directly because branch-4.1 does not emit binlog.format, so this backport preserves the complete branch-4.1 baseline and adds matching replica-1/replica-3 result blocks.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Issue Number: None

Related PR: None

Problem Summary: The SHOW CREATE TABLE case always expected one replica even when test environments force OLAP tables to three replicas. Select the full golden matching the effective force replica configuration while preserving the existing one-replica baseline.

None

- Test: Regression test

    - test_show_create_table_and_views_nereids with force replica 3

- Behavior changed: No

- Does this need documentation: No

(cherry picked from commit 051a02b)
@shuke987
shuke987 requested a review from yiguolei as a code owner July 15, 2026 15:01
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987

Copy link
Copy Markdown
Contributor Author

run buildall

@shuke987

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review completed for PR #65673. I did not find a blocking issue.

Checked:

  • The Groovy suite computes the effective replica count from force_olap_table_replication_allocation before force_olap_table_replication_num, matching the FE forced-replica precedence.
  • The dynamic quickRunTest tags line up with the new replica-1 and replica-3 golden blocks, and the regression output iterator skips unused alternate blocks safely.
  • SHOW CREATE TABLE, rollup, and CREATE TABLE LIKE paths continue to serialize the default-tag replica allocation as expected for the intended branch-4.1 forced-replica case.
  • The changed-file sweep covered both changed files. Existing inline comments: none. Additional user focus: none.

Validation: static review plus git diff --check on the prompted range passed. I did not run the regression suite in this runner. The main review, two normal subagents, and the risk-focused subagent all converged with NO_NEW_VALUABLE_FINDINGS, so no inline comments are proposed.

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei
yiguolei merged commit 54be788 into apache:branch-4.1 Jul 16, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants