[style](index) Translate SNII comments and test diagnostics to English - #67808
Open
airborne12 wants to merge 1 commit into
Open
[style](index) Translate SNII comments and test diagnostics to English#67808airborne12 wants to merge 1 commit into
airborne12 wants to merge 1 commit into
Conversation
### What problem does this PR solve? Related PR: apache#67537 Problem Summary: The SNII implementation and tests touched by apache#67537 contain Chinese comments and golden-corpus diagnostics. Translate this explanatory text to English, including the related FE policy and protobuf comments. Preserve Unicode test inputs, executable logic, query expectations, and the on-disk format. Clarify that a control-byte sample is not the full internal marker and that missing golden expectations fail verification. ### Release note None ### Check List (For Author) - Test - [x] Manual test: tokenized comparison of all 51 changed files confirms identical executable tokens except seven translated test diagnostics; all Unicode input data is preserved and no Chinese comments remain. Changed-file clang-format 16 and BE build-hygiene checks pass. - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - Behavior changed: - [x] No. Only explanatory comments and test diagnostic wording change. - Does this need documentation? - [x] No. No external documentation changes are required.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #67537
Problem Summary:
The SNII code and tests touched by #67537 contain Chinese comments and golden-corpus diagnostics. Translate that explanatory text to English, including the related FE policy and protobuf comments. Preserve all Unicode test inputs, executable logic, query expectations, and the on-disk format.
Also clarify two comments against the existing behavior: the control-byte sample is not the full internal marker, and missing golden expectations fail verification.
Release note
None
Check List (For Author)
Validation:
Tokenized C++/Java/Protobuf comparison of all 51 changed files: executable tokens are unchanged except seven translated test diagnostics; Unicode input data is preserved.
Source scan: no Chinese comments remain in the changed files.
Full merged-tree C++ clang-format 16 check passed across BE and Cloud sources/tests.
Full merged-tree FE
mvn clean checkstyle:checkpassed with JDK 17 and zero violations.bash build-support/check-build-hygiene.shandgit diff --checkpassed.No database build, unit-test execution, or regression cluster was needed for these comment/diagnostic-only edits.
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)