Repository navigation
fix: scope discovery informer known objects to each mesh - #1638
Open
AsperforMias wants to merge 3 commits into
Open
AsperforMias wants to merge 3 commits into
AsperforMias wants to merge 3 commits into
Conversation
robocanic
reviewed
Nov 14, 2026
robocanic
left a comment
Contributor
There was a problem hiding this comment.
I traced the relist through DeltaFIFO.KnownObjects and the discovery store adapter. Filtering both ListKeys and GetByKey by exact mesh identity keeps another registry’s metadata out of replacement tombstones, while a missing key in the same mesh can still generate a delete. The regression tests cover both registry orderings and same-mesh stale deletion. I found no blocking issue in this change. The discovery package passed in Actions; the failing metric dashboard assertion is addressed separately in #1642.
…k-service-catalog
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please provide a description of this PR:
Discovery informers list resources for one mesh, but use a resource store shared across meshes. During a list replacement, an informer can therefore treat another mesh's resources as deleted. For example, a Nacos refresh can remove ZooKeeper service metadata from the Admin catalog even though the ZooKeeper nodes still exist.
Scope each discovery informer's known-object view to its mesh. Both ListKeys and GetByKey use exact mesh identity, while stale-resource deletion and watch updates/deletions within the same mesh remain unchanged. The change stays within discovery and does not modify the shared controller.
Tests cover both cross-mesh ordering directions, mesh names containing slashes, stale-resource deletion, watch updates/deletions, and relisting. The regression fails on the original implementation and passes with this change. Targeted tests, race tests, vet, and lint for the changed package pass.
Real Nacos/ZooKeeper checks passed after two independent Admin restarts using this patch. Service lists, details, methods, and non-IDL invocation remained available.
The adapter scans the existing per-kind List view. It does not change the store's existing list-error handling contract.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.