[hotfix] disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache#27969
Open
Manishnemade12 wants to merge 2 commits into
Open
[hotfix] disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache#27969Manishnemade12 wants to merge 2 commits into
Manishnemade12 wants to merge 2 commits into
Conversation
… on seek errors in ChangelogStreamHandleReaderWithCache
Collaborator
spuru9
reviewed
Apr 29, 2026
Contributor
spuru9
left a comment
There was a problem hiding this comment.
@Manishnemade12 Can you add [hotfix] to the PR and update the PR description as per the new guidelines.
Author
@spuru9 i did changes . can you please review it now |
spuru9
suggested changes
May 1, 2026
Contributor
spuru9
left a comment
There was a problem hiding this comment.
You would need to run mvn spotless:apply
…urce cleanup in ChangelogStreamHandleReaderWithCache
Author
|
@spuru9 i addressed all comment , can you please took once look there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[hotfix] disk space and file descriptor leaks in ChangelogStreamHandleReaderWithCache
What is the purpose of the change
This pull request fixes severe disk space and file descriptor leaks in
ChangelogStreamHandleReaderWithCachethat occur during filesystem or network errors. This is a hotfix because the leaks can cause TaskManager crashes due to exhausted disk space or file descriptors and should be applied to affected stable branches as appropriate.Previously, if a network cluster error disrupted DFS stream copying in
downloadToCacheFile, the partially transferred temporary cache file was permanently left on disk, eventually causing disk full crashes on TaskManagers. Furthermore, ifopenAndSeekthrew anIOExceptionduring channel positioning, the instantiatedFileInputStreamwas leaked without being closed, exhausting OS file handles.Brief change log
file.delete()on the target temporary block when anIOExceptionis encountered during DFS buffer copying indownloadToCacheFile, ensuring partial temporary files are removed on failures.fin.getChannel().position(offset)call inopenAndSeekwith atry-catchthat guaranteesIOUtils.closeQuietly(fin)is called if positioning fails, preventing leakedFileInputStreaminstances.Verifying this change
This change is already covered by existing tests, such as the Changelog State Backend recovery tests that implicitly exercise filesystem operations and DFS stream caching logic.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation