FLINK-37686 - Do not fail on NOT_OWNED deleted files - #28801
Conversation
|
@francis-a Thanks for the PR. LGTM. The orphan files deleted by the JM are abandoned by ForSt. They should be removed and not cause failures during a full scan. @Zakelly Could you take a look? |
Zakelly
left a comment
There was a problem hiding this comment.
LGTM, @francis-a thanks for the fix
|
@flinkbot run azure |
|
thanks @Zakelly, do you plan on handling merging? Is there anything else I should do? |
@francis-a yeah, I was about to merge but the CI failed. I think it's irrelevant but the CI bot is not responding to the re-run request. It would be nice if you could amend the commit and force push once, to re-trigger the CI. |
f71b66e to
b38fd53
Compare
|
@Zakelly done |
|
It doesn't look like checks are running, I'll push a minor change |
What is the purpose of the change
This PR aims to fix the issue documented in https://issues.apache.org/jira/browse/FLINK-37686 where remote objects cleaned up by the JM cause checkpoint failures even when the object is marked as
NOT_OWNED.Brief change log
FileNotFoundExceptioncatch block toForStFlinkFileSystem::listStatusNOT_OWNEDFileMappingManagerNOT_OWNEDVerifying this change
This change added tests and can be verified as follows:
ForStFlinkFileSystemTest,testListStatusDropsDeletedNotOwnedEntryAfterGiveUpOwnershipandtestListStatusStillFailsForDeletedDbOwnedFileNOT_OWNEDand verify the removed object is also removed from theFileMappingManager, the other test verifies the baseline hasn't changed for other object typesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus]