Repository navigation
HBASE-30453 BucketCache region cached size is not decremented on eviction for non-persistent IOEngines - #8737
Open
julianchandras wants to merge 2 commits into
Open
julianchandras wants to merge 2 commits into
julianchandras wants to merge 2 commits into
Conversation
…tion for non-persistent IOEngines
wchevreuil
reviewed
Oct 6, 2026
| // This computation should happen even if the file is not in fullyCachedFiles map. | ||
| updateRegionCachedSize(key, (entry.getLength() * -1)); | ||
| fullyCachedFiles.remove(key.getHfileName()); | ||
| private void fileNotFullyCached(String hfileName) { |
Contributor
There was a problem hiding this comment.
nit: since fileNotFullyCached now became a single liner delegation to fullyCachedFiles.remove, can we remove fileNotFullyCached altogether and simply call the fullyCachedFiles.remove directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30432
regionCachedSize was decremented only in fileNotFullyCached, which blockEvicted calls only for persistent IOEngines, so offheap evictions were never subtracted. Moved the decrement into blockEvicted to mirror the increment in putIntoBackingMap.
This also fixes a double decrement in the persistent cache validation thread (evictBlock followed by fileNotFullyCached) that occurred before the fix.
Tests: