HIVE-29765: HiveBetween#unparse ignores negated flag

[rubenada]

What changes were proposed in this pull request?

HiveBetween#unparse will consider the negated flag.

Why are the changes needed?

Fix the unparse of NOT BETWEEN.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

[ayushtkn]

Does it lead to any query level failure or so? If so can we extend a test?

[rubenada]

@ayushtkn it seems this was untested, I will prepare a test

[rubenada]

@ayushtkn I included a new unit test, could you please take another look?

[ayushtkn]

@rubenada why are we going with Junit style test, can't we we have a q file test?

[rubenada]

@ayushtkn it was simpler. It seems in practice the "NOT BETWEEN" operator is currently not generated in the intermediate planner conversions (that's probably why this bug went under the radar).
There's a PR to "enable" it (which unveiled the current issue): #6634 ; but there are some discussions on that Jira whether or not we should really apply that change, so that one may not land in master.
Nevertheless, we would need to fix this bug.

[sonarqubecloud]

Quality Gate passed

Issues
33 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud