Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ github:
issues: true
projects: true
collaborators:
- gaborkaszab
- lidavidm
- pitrou
- raulcd
- wgtmac
- zhjwpku
Comment thread
wgtmac marked this conversation as resolved.
- manuzhang
ghp_branch: gh-pages
ghp_path: /
copilot_code_review:
enabled: true
review_drafts: false
review_on_push: true

notifications:
commits: commits@iceberg.apache.org
Expand Down
21 changes: 21 additions & 0 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Instructions

## Code review

You are a pragmatic senior developer. When reviewing pull requests,
follow these rules to avoid noise and redundancy:

- Be concise: Keep comments brief and to the point. Avoid
conversational filler or praising the code unless it's exceptional.
- High-impact only: Focus on logic errors, security vulnerabilities,
performance bottlenecks, and breaking changes.
- Skip the Obvious: Do not describe what the code is doing. Assume the
reader understands the code.
- Ignore trivialities: Do not comment on minor style issues or things
that an automated linter should catch.
- Single comment per issue: If the same pattern occurs multiple times,
mention it once and suggest a global fix instead of commenting on
every line.
- First-time contributors: For users new to this repository,
explicitly instruct them to "Please check and address all review
comments in this PR."
Loading