Skip to content

feat(php): map Iggy errors to typed exceptions#3382

Merged
hubcio merged 4 commits into
apache:masterfrom
WaterWhisperer:feat/php-typed-exceptions
Jun 2, 2026
Merged

feat(php): map Iggy errors to typed exceptions#3382
hubcio merged 4 commits into
apache:masterfrom
WaterWhisperer:feat/php-typed-exceptions

Conversation

@WaterWhisperer
Copy link
Copy Markdown
Contributor

Which issue does this PR address?

Closes #3294

Rationale

The PHP SDK exposed Iggy failures as generic PHP exceptions, so callers could not reliably handle common error categories without parsing exception messages.

What changed?

Maps IggyError to typed PHP exceptions under Iggy\Exception.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

  1. AI tools used: Codex
  2. Scope of usage: explanation, validation commands
  3. Verification: validated with commands
  4. Yes

@github-actions
Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 31, 2026
Comment thread foreign/php/src/error.rs
Comment thread foreign/php/src/lib.rs
Comment thread foreign/php/src/error.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jun 1, 2026
@WaterWhisperer WaterWhisperer force-pushed the feat/php-typed-exceptions branch from 22fc455 to 3109941 Compare June 2, 2026 09:43
@WaterWhisperer
Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Jun 2, 2026
@hubcio hubcio merged commit 7bbe10c into apache:master Jun 2, 2026
31 checks passed
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Jun 2, 2026
@WaterWhisperer WaterWhisperer deleted the feat/php-typed-exceptions branch June 2, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map PHP SDK errors to typed exception classes

3 participants