fix(pipe): reuse safe local progress on alter - #18423
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
jt2594838
reviewed
Aug 10, 2026
jt2594838
left a comment
jt2594838
left a comment
Contributor
There was a problem hiding this comment.
Is it possible to add an IT that tests altering an pipe does not re-send already received data?
Comment on lines
+232
to
+233
| * MinimumProgressIndex}), and leader changes must use the coordinator checkpoint because the old | ||
| * task is not local to the new leader. |
Contributor
There was a problem hiding this comment.
Is it possible to report the progress to the leader before the changes, so that even the new leader may have the latest progress?
Comment on lines
+58
to
+69
| default boolean handlePipeMetaChanges( | ||
| final List<ByteBuffer> pipeMetas, | ||
| final List<TPushPipeMetaRespExceptionMessage> exceptionMessages) | ||
| throws Exception { | ||
| for (final ByteBuffer pipeMeta : pipeMetas) { | ||
| final TPushPipeMetaRespExceptionMessage message = handleSinglePipeMeta(pipeMeta); | ||
| if (message != null) { | ||
| exceptionMessages.add(message); | ||
| } | ||
| } | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
What is the meaning of the return value?
Comment on lines
+84
to
+86
| if (!handler.handlePipeMetaChanges(req.getPipeMetas(), exceptionMessages)) { | ||
| return new TPushPipeMetaResp() | ||
| .setStatus(new TSStatus(TSStatusCode.PIPE_PUSH_META_TIMEOUT.getStatusCode())); |
Contributor
There was a problem hiding this comment.
I cannot associate returning false with timeout from the implementation above.
Please give some explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tests: