Subscription: clean up consumers after abrupt disconnect - #18434
Open
Caideyipi wants to merge 1 commit into
Open
Subscription: clean up consumers after abrupt disconnect#18434Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
An abruptly terminated consumer does not send close or unsubscribe requests. The server previously removed its receiver from timeout tracking and cleared the receiver's shared consumer state during connection cleanup, so the orphaned consumer could retain uncommitted subscription data indefinitely. That retained data can exhaust shared subscription memory and block message admission for unrelated topics and consumers.
Tests
mvn -o -nsu spotless:check -pl iotdb-core/datanodeSubscriptionReceiver*.java(0 violations)SubscriptionReceiverAgentTest: 4 tests passedSubscriptionReceiverV1Test: 9 tests passed