Upgrade to yarn modern - #4089
Conversation
9349e17 to
92b86dc
Compare
|
Having this would be very good! Jena can't stay on yarn1 forever. The weekly set of JS updates that happen every week (wednesdays, but also some out of cycle at the weekend) are down to yarn1 no longer being mainatined. |
|
Will reset to main and rerun migrations to yarn2 and removals. The change worked/was built succesfully before 6.2 on all github actions, as well as MacOS locally. Also removes some dependencies, but should confirm that the different environments still works. |
92b86dc to
cb544c2
Compare
cb544c2 to
2bae46b
Compare
|
This looks ready for review and passes CI in
However fails locally, when trying to download corepack (complains about the timestamp of the Cookie, could be timezone related). Next run passed Since the lock file diff is so huge, I could rather add the non-used dependencies as a secondary PR if needed, but I think the package workarounds for installation failed, so the clean up started from failures. see the commit tag for more description of the changes 2bae46b The removed dependencies are investigated with knip (knip.dev), as well as code-search. I did not add the knip configs since I didn't want to add more dependencies. |
| "built": true | ||
| } | ||
| }, | ||
| "packageManager": "yarn@4.18.0" |
There was a problem hiding this comment.
Maybe not necessary because I don't see it in other package.json deps, but a integrity hash was dropped.
|
I gave this a local run to compare against a failing test I have in another PR and came across the corepack warning. I think this was from my stale node folder because after deleting and retrying I was free of the warning. It also looks like the warnings from #4053 are gone, too! I noticed, locally, a .yarn getting created and it could be added to the gitgnore with these rules |
…kages
- Yarn: Migrate lock file with `corepack enable`, ‘yarn set version berry` and `yarn install`
- Maven/pom.xml: Use Corepack-managed Yarn 4 with immutable installs
- Yarn: Disable dependency lifecycle scripts by default and allow reviewed builds
- Yarn: Disallow git repos by default and allow fetching yasgui-geo-tg
- Update Maven frontend executions for Corepack
- Simplify cross-platform E2E and offline-serving scripts
- Remove obsolete dependencies and update Vue compiler configuration
- @cypress/vue: legacy standalone mount package; Cypress 15 provides Vue
mount via core (cypress/vue) and no component specs exist
- @types/codemirror: types for CodeMirror 5, but the editor uses
CodeMirror 6 (codemirror@6 + @codemirror/*, which ship their own types)
- eslint-plugin-promise: not referenced by any ESLint flat config
- express: no imports (only matched the Apache license header)
- nanoid: no imports
- Remove @vue/compat: the Vue 3 migration-build compat layer was declared
but never aliased in the Vite config, so it was unused
- Remove @vue/eslint-config-standard and eslint-plugin-import: superseded by
the ESLint flat config (@eslint/js + eslint-plugin-vue)
- Remove follow-redirects: unused direct dependency, resolved transitively
via the lockfile with no source imports
- Drop cross-env and run-script-os: E2E/offline scripts rewritten to POSIX
env syntax, dropping the separate win32 variant
- apacheGH-4090: Enable Cypress coverage collection
- Regenerate the Yarn lockfile and update RAT exclusions
- apacheGH-4053: Upgrading to Yarn-modern removes warnings
- Remove obsolete js config files (.eslintrc.js, plugins/index.js, support/vite-preprocessor.js) superseded by flat ESLint config, setupNodeEvents, and cypress-vite
2bae46b to
7535445
Compare
|
Got an unrelated(?) failure on the PR after force pushing rerunning worked. |
I did a repo clone of OyvindLGjesdal:upgrade-to-yarn-modern and got a clean build. |
GitHub issue resolved #4075, #4053 and #4090
Pull request Description:
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.