KAFKA-20417: Add KIP-1035 self-managed offset lifecycle integration tests#21999
Open
bbejeck wants to merge 2 commits intoapache:trunkfrom
Open
KAFKA-20417: Add KIP-1035 self-managed offset lifecycle integration tests#21999bbejeck wants to merge 2 commits intoapache:trunkfrom
bbejeck wants to merge 2 commits intoapache:trunkfrom
Conversation
c1f15d3 to
a9ad811
Compare
Member
Author
|
@mjsax rebased PR |
mjsax
reviewed
Apr 10, 2026
| // After clean shutdown with no data, status should still be closed | ||
| assertStoreStatus(0L); | ||
|
|
||
| // Restart — should not treat empty CF as corruption |
mjsax
reviewed
Apr 10, 2026
Member
mjsax
left a comment
There was a problem hiding this comment.
Overall LGTM. Just one question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SelfManagedOffsetLifecycleIntegrationTest— companion to therecovery tests.
Validates the happy path for column-family-based offset management.
After each clean shutdown, tests directly inspect the CF to assert
status=closed and offsets populated. Covers:
restart cycles - No changelog restoration after clean shutdown (via
StateRestoreListener) - Clean restart with no data processed
All tests parameterized for ALOS and EOS.
Reviewers: Matthias J. Sax matthias@confluent.io