Skip to content

Fix artifact relocation support#1633

Merged
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:fix-relocation
May 24, 2026
Merged

Fix artifact relocation support#1633
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:fix-relocation

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

  • Update ITs for copy, unpack, and relocation use cases.
  • Simplify and align artifact verification in integration tests.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

- Update ITs for `copy`, `unpack`, and relocation use cases.
- Simplify and align artifact verification in integration tests.
@slawekjaranowski slawekjaranowski requested a review from cstamas May 23, 2026 20:10
@slawekjaranowski slawekjaranowski self-assigned this May 23, 2026
@slawekjaranowski slawekjaranowski added the bug Something isn't working label May 23, 2026
@slawekjaranowski slawekjaranowski added this to the 3.11.0 milestone May 23, 2026
@slawekjaranowski slawekjaranowski merged commit 3712611 into apache:master May 24, 2026
17 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-relocation branch May 24, 2026 12:28
@hboutemy
Copy link
Copy Markdown
Member

if this is a fix, it means something was not working as expected?
what was expected that actual was not ok?

it's hard to review

@slawekjaranowski
Copy link
Copy Markdown
Member Author

@hboutemy it fix linked issue

reproduce:
add src/it/mrm/repository/ResourceArtifact-relocation-1.0.pom artifact with relocation information

next it is used in src/it/projects/copy-relocation/pom.xml and in verification src/it/projects/copy-relocation/verify.groovy we see that artifact ResourceArtifact-1.0.jar was used - so information about relocation was consider

@hboutemy
Copy link
Copy Markdown
Member

ok, I did not see linked issue: I'm definitively lost with GH issues...
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency plugin 3.9.0 now fails to respect/follow relocated module artifacts

3 participants