Skip to content

PHP 8.4 property hook#9281

Closed
haidubogdan wants to merge 1 commit intoapache:masterfrom
haidubogdan:php84-property-hooks-bh
Closed

PHP 8.4 property hook#9281
haidubogdan wants to merge 1 commit intoapache:masterfrom
haidubogdan:php84-property-hooks-bh

Conversation

@haidubogdan
Copy link
Copy Markdown
Contributor

@haidubogdan haidubogdan commented Mar 17, 2026

Seems to work fine.

Some things to fix

  1. Fix highlighting of private methods not being used
image

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@haidubogdan haidubogdan added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 17, 2026
- continue from @junichi11 pull request without some syntax changes
- Closes apache#8035

- revert PHP5ErrorHandlerImpl.java changes to avoid changes on some unrelated tests
- unit tests error using curly brackets are affected due to the property hook parser rule
@haidubogdan haidubogdan force-pushed the php84-property-hooks-bh branch from 59d2fe1 to ed98d2e Compare March 18, 2026 00:28
@junichi11
Copy link
Copy Markdown
Member

junichi11 commented Mar 18, 2026

Please don't do this because I'll do it myself.

If there are problems, please write them to the original PR.

@haidubogdan
Copy link
Copy Markdown
Contributor Author

Please don't do this because I'll do it myself.

If there are problems, please write them to the original PR.

Ok, thank you.
I will close the PR, it was a helpful way to understand the implementation :) .
Regarding the unused private method highlight, it seems to be more of a ParserVisitor sequence issue, so, I think it's not that relevant for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP [ci] enable extra PHP tests (php/php.editor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4 Support

2 participants