Skip to content

Added basic type checks in java.lsp.server config change listeners#9369

Open
sid-srini wants to merge 1 commit intoapache:masterfrom
sid-srini:lsp-server-config-listeners-null-check
Open

Added basic type checks in java.lsp.server config change listeners#9369
sid-srini wants to merge 1 commit intoapache:masterfrom
sid-srini:lsp-server-config-listeners-null-check

Conversation

@sid-srini
Copy link
Copy Markdown
Contributor

  • Added checks for null and required JsonElement type in the registered config change listeners in WorkspaceService.
  • Included a check for blank input defaultPlatformOverride in AbstractJavaPlatformProviderOverride to avoid expensive initialization in such cases.
  • Included a unit test for config values reset to null being received as a JsonNull value.

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

- Added checks for null and required JsonElement type in the registered
  config change listeners in WorkspaceService.
- Included a check for blank input defaultPlatformOverride in
  AbstractJavaPlatformProviderOverride.
- Included a unit test for config values reset to null received as a
  JsonNull value.
@Achal1607 Achal1607 added LSP [ci] enable Language Server Protocol tests VSCode Extension labels Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LSP [ci] enable Language Server Protocol tests VSCode Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants