Repository navigation
examples/nxflatxip: Update the header comment of the module. - #3863
Merged
Merged
Conversation
The comment said that the module has no static data and no strings because of bugs in the ldnxflat in circulation, and that the firmware is entered with the data base in r10. ldnxflat is now in the NuttX tree (tools/nxflat) without these bugs, and the PIC base register is r9. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
xiaoxiang781216
approved these changes
Oct 17, 2026
acassis
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The header comment of
examples/nxflatxip/module/xipmod.csaid that the module has no static data and no strings because the ldnxflat "in circulation" points the GOT entries of.bssinto the import table and drops the addend of PC-relative.rodatareferences, and that the firmware is entered with the module's data base in r10.Since apache/nuttx#20377, ldnxflat is in the NuttX tree (
tools/nxflat) without these bugs, and the NXFLAT PIC base register is r9. The comment now says so; the module itself does not change.Impact
Comment only.
Testing
tools/checkpatch.sh -c -u -m -gpasses.