tools/nxstyle: indent code against its enclosing brace, not modulo 4 - #19933
Open
raiden00pl wants to merge 1 commit into
Open
tools/nxstyle: indent code against its enclosing brace, not modulo 4#19933raiden00pl wants to merge 1 commit into
raiden00pl wants to merge 1 commit into
Conversation
A residue modulo four expresses neither the indentation unit nor the alignment of case logic, and all of it was disabled from the first switch to the end of the enclosing function. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
raiden00pl
force-pushed
the
nxstyle_fixes_pr3
branch
from
August 23, 2026 08:01
d7e4dfe to
1a176b4
Compare
raiden00pl
marked this pull request as ready for review
August 23, 2026 08:05
raiden00pl
requested review from
davids5,
jerpelea and
johannes-nivus
as code owners
August 23, 2026 08:05
xiaoxiang781216
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/nxstyle: indent code against its enclosing brace, not modulo 4
Impact
nuttx standard compatibility
Testing
correctly detect wrong alignment like below: