[core] Optimize String format in CacheManager#7856
Merged
Conversation
leaves12138
approved these changes
May 19, 2026
Contributor
leaves12138
left a comment
There was a problem hiding this comment.
Looks good to me.
This change is a small cleanup in CacheManager: it switches from eager String.format(...) to the existing Preconditions.checkNotNull(reference, template, args...) overload, so the error message is only formatted on the null path. The checkNotNull overload supports %s templates, so the behavior remains equivalent when the cache lookup unexpectedly returns null.
I reviewed the diff and checked the corresponding Preconditions API. The existing failing CI job looks unrelated to this one-line change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests