[core] DataEvolution table supports concurrent updates to different columns#7867
Open
steFaiz wants to merge 8 commits into
Open
[core] DataEvolution table supports concurrent updates to different columns#7867steFaiz wants to merge 8 commits into
steFaiz wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, if we concurrently trigger columns update jobs for data evolution table, the later jobs will be failed:

This happens even we are updating different columns.
However, we could only forbid updating the same columns. This PR introduces a RowIdColumnConflictChecker and use binary search to accelerate check process.
BenchMark
I tested 100000 files with disjoint row range check against 100000 files with disjoint row range, each file contains 3 columns, the result is:
with binary search, the check cost is negligible.
Tests
UT Cases for Spark and Unit Tests for core.