[python] Fix Arrow offset overflow in merge condition filtering - #9678
Draft
XiaoHongbo-Hope wants to merge 3 commits into
Draft
[python] Fix Arrow offset overflow in merge condition filtering#9678XiaoHongbo-Hope wants to merge 3 commits into
XiaoHongbo-Hope wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix conditional self-merge failures when the combined size of Arrow
string,binary, or other 32-bit-offset columns exceedsINT32_MAX.filter_batchpreviously registered every input RecordBatch in one DataFusion partition. DataFusion could concatenate those batches while evaluating the condition, causing an offset overflow even though each individual Arrow batch was valid.Changes
collect_partitioned()and rebuild the Arrow table in partition order, preserving both chunk boundaries and input row order.The fix preserves the existing Arrow schema instead of casting columns to
large_stringorlarge_binary.Tests
134 passedinray_data_evolution_merge_into_test.py26 passedintable_merge_into_test.py6 passedinconcat_batch_reader_test.pygit diff --check