PARQUET-3364: Allow hyphens in column names in AvroSchemaConverter#3524
Open
yadavay-amzn wants to merge 1 commit intoapache:masterfrom
Open
PARQUET-3364: Allow hyphens in column names in AvroSchemaConverter#3524yadavay-amzn wants to merge 1 commit intoapache:masterfrom
yadavay-amzn wants to merge 1 commit intoapache:masterfrom
Conversation
The Parquet spec allows any UTF-8 string as a field name, but the AvroSchemaConverter was failing when converting Parquet schemas with field names containing hyphens (e.g. "Creation-Time") to Avro schemas, because Avro name validation rejects non-alphanumeric/underscore chars. Fix: temporarily disable Avro name validation during Parquet-to-Avro schema conversion, since the names are already valid per the Parquet spec. Closes apache#3364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3364
Problem
parquet cat(and other CLI commands) reject valid Parquet files with column names containing hyphens (e.g.Creation-Time). The Parquet spec allows any UTF-8 string as a field name, but theAvroSchemaConverterfails because Avro'sSchema.Fieldname validation only allows[A-Za-z_][A-Za-z0-9_]*.Fix
Temporarily disable Avro name validation during Parquet-to-Avro schema conversion in
AvroSchemaConverter.convert(). The field names are already valid per the Parquet spec — the restriction is purely an Avro naming convention that should not apply when reading Parquet files.Testing
testHyphenatedColumnNametest inTestAvroSchemaConverter