Repository navigation
fix : UpstreamCheckUtils.checkUrl param add protocol. - #6252
BraveheartStone wants to merge 12 commits into
Conversation
If the protocol parameter is not added, when shenyu.upstreamCheck.enabled=true is configured in shenyu-bootstrap, the port numbers checked in the UpstreamCheckUtils.checkUrl method will all be port 80. The host using the HTTPS protocol will not be checked on port 443, resulting in the health check failing continuously.
|
@BraveheartStone hi, plx fix ci |
Aias00
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES (PMC Aias00): this PR has merge conflicts (CONFLICTING) and cannot be merged. Please rebase onto the latest master and resolve the conflicts, then request a re-review.
|
Re-check: this branch is still CONFLICTING with master, and the grpc e2e case plus |
|
Hi @BraveheartStone, this PR has been in To keep the review queue healthy, please either:
If there are no plans to continue, we may close it for staleness — happy to reopen if you pick it up later. Thanks! |
|
Hi @BraveheartStone, this PR currently has merge conflicts with the |
If the protocol parameter is not added, when shenyu.upstreamCheck.enabled=true is configured in shenyu-bootstrap, the port numbers checked in the UpstreamCheckUtils.checkUrl method will all be port 80. The host using the HTTPS protocol will not be checked on port 443, resulting in the health check failing continuously.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.