SOLR-18122: Remove deprecated class

[utsav00]

https://issues.apache.org/jira/browse/SOLR-18122

Description

Remove the deprecated VMParamsAllAndReadonlyDigestZkACLProvider class as part of the Solr 10 deprecated-code cleanup

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide
• I have added a changelog entry for my change

[epugh]

LGTM. Having said that, it feels like there should be more of a pointer to the fix, but this also seems so down in the weeds that maybe that doesn't matter. Sigh, ignore my angst. I triggered the run, and assuming it passes will merge.

[Copilot]

Pull request overview

Removes the deprecated ZooKeeper ACL provider VMParamsAllAndReadonlyDigestZkACLProvider from solrj-zookeeper as part of Solr 10 deprecated-code cleanup (SOLR-18122), and documents the removal for upgraders and release notes.

Changes:

• Delete deprecated VMParamsAllAndReadonlyDigestZkACLProvider implementation (no remaining in-repo references found).
• Add Solr 10 upgrade note pointing users to DigestZkACLProvider + VMParamsZkCredentialsInjector.
• Add an unreleased changelog entry marking the class removal.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/VMParamsAllAndReadonlyDigestZkACLProvider.java	Removes deprecated ACL provider class.
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc	Documents the removal and replacement approach for Solr 10 upgrades.
changelog/unreleased/SOLR-18122-remove-vmparams-acl-provider.yml	Adds changelog entry describing the removal.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[utsav00]

LGTM. Having said that, it feels like there should be more of a pointer to the fix, but this also seems so down in the weeds that maybe that doesn't matter. Sigh, ignore my angst.

Haha, I get it. I followed the 9.x convention. And did add a reference of what to use in its stead in the changelog and guide. Can also add a xref to the 9.x note but I think it's minor. Lmk if you were thinking in another direction

I triggered the run, and assuming it passes will merge.

Thank you 🙌

[utsav00]

@epugh, can you approve the pending workflow here?

[epugh]

need to confirm we can remove this from branch_10x as well as main branch, or jsut main...