SOLR-18314: update both DisMax and eDisMax parsers to skip phrase ana… - #4652
Open
ispringer wants to merge 4 commits into
Open
SOLR-18314: update both DisMax and eDisMax parsers to skip phrase ana…#4652ispringer wants to merge 4 commits into
ispringer wants to merge 4 commits into
Conversation
…lysis entirely for single-term queries, since a one-word phrase is semantically meaningless
dsmiley
reviewed
Jul 30, 2026
added 2 commits
July 30, 2026 13:49
…the removal of the single-term phrase boost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lysis entirely for single-term queries, since a one-word phrase is semantically meaningless
https://issues.apache.org/jira/browse/SOLR-18314
Description
Both DisMax and eDisMax parsers should skip phrase analysis entirely for single-term queries, since a one-word phrase is semantically meaningless.
Solution
(coded by Claude Sonnet 4.6)
DisMax (
DisMaxQParser.java:230-232): Added an earlyreturn nullwhen the stripped query is blank or contains no whitespace (single term). This avoids wrapping a lone token in quotes and running it through the phrase parser for no benefit.eDisMax (
ExtendedDismaxQParser.java:633): Addedif (shingleSize < 2) return;after thepfshingle size is resolved from 0 toclauses.size(). This short-circuits before constructing a query string, instantiating a parser, and parsing — all of which was previously done only to be discarded byminClauseSize=2downstream.Tests
Ran the tests for both query parsers:
Result: 41 tests passed (38 from TestExtendedDismaxParser, 3 from DisMaxRequestHandlerTest)
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.