Simplify SolrRequest path usage: prefer ctor not setPath - #4689
Merged
Conversation
QueryRequest's constructors already resolve the "qt" param into the request path, so callers no longer need to manually extract/remove qt and call setPath themselves.
And don't use QueryRequest for non-SearchHandler.
github-actions
Bot
added
documentation
epugh
approved these changes
Jul 31, 2026
| } | ||
| QueryRequest request = new QueryRequest(params); | ||
| request.setPath("/admin/collections"); | ||
| var request = |
Contributor
There was a problem hiding this comment.
Normally when I see a GSR I think "We should be using one of our strongly typed OpenAPI classes" ;-). But in this case, I think it's better ;-).
| throws Exception { | ||
| QueryRequest query = new QueryRequest(args); | ||
| query.setResponseParser(new SmileResponseParser()); | ||
| String path = args.get("qt"); |
Contributor
There was a problem hiding this comment.
Love seeing another qt bite the dust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify qt/path handling in QueryRequest callers
QueryRequest's constructors already resolve the "qt" param into the
request path, so callers no longer need to manually extract/remove
qt and call setPath themselves.
Tests: SolrRequest path usage: prefer ctor not setPath
And don't use QueryRequest for non-SearchHandler.