Improve/Refactor MBean Utilities and Add Unit Tests for Catalina MBeans#987
Open
onkar717 wants to merge 1 commit intoapache:mainfrom
Open
Improve/Refactor MBean Utilities and Add Unit Tests for Catalina MBeans#987onkar717 wants to merge 1 commit intoapache:mainfrom
onkar717 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves test coverage for the
ssimodule by addingunit and integration tests for core classes that previously had
little to no coverage.
Motivation
During analysis of overall test coverage, the
ssimodule wasidentified as having several untested or under-tested classes.
These classes are responsible for Server Side Includes (SSI)
processing, including expression parsing, conditional evaluation,
and servlet-based rendering, making them critical for correctness
and stability.
This PR introduces targeted tests to validate core behaviors,
edge cases, and integration scenarios across the module.
Changes
ExpressionTokenizer
Added
TestExpressionTokenizercovering:ByteArrayServletOutputStream
Added
TestByteArrayServletOutputStreamcovering:ServletOutputStreamcontract methodsSSIConditionalState
Added
TestSSIConditionalStatecovering:SSIStopProcessingException
Added
TestSSIStopProcessingExceptioncovering:SSIServlet
Added
TestSSIServletcovering:SSI directive processing using embedded Tomcat:
echosetif/elseconditional logicprintenv,config, andfsizedirectivesSecurity restrictions for
WEB-INFandMETA-INFEnd-to-end request handling and response generation
Testing
All tests pass locally:
ant clean testTargeted validation was performed for each new test class with no failures.
Test results:
Coverage Impact
This PR significantly improves coverage for the
ssimodule,which previously had minimal or no dedicated test coverage.
The following core classes are now covered:
ExpressionTokenizerByteArrayServletOutputStreamSSIConditionalStateSSIStopProcessingExceptionSSIServletThis establishes a strong foundation for further coverage
improvements in remaining SSI-related components.
Impact
Files Changed
TestExpressionTokenizer.java(new)TestByteArrayServletOutputStream.java(new)TestSSIConditionalState.java(new)TestSSIStopProcessingException.java(new)TestSSIServlet.java(new)Checklist
ant clean test