Skip to content

[CI] Add TIRX tests to CI#19600

Open
tlopex wants to merge 4 commits into
apache:mainfrom
tlopex:fix226
Open

[CI] Add TIRX tests to CI#19600
tlopex wants to merge 4 commits into
apache:mainfrom
tlopex:fix226

Conversation

@tlopex
Copy link
Copy Markdown
Member

@tlopex tlopex commented May 25, 2026

This PR adds tests/python/tirx to the general Python unittest CI.

Previously, task_python_unittest.sh only ran:

  • tests/python/tirx-analysis
  • tests/python/tirx-base
  • tests/python/tirx-transform

but did not run the TIRX DSL/operator/codegen tests under tests/python/tirx.

This PR adds tirx to TEST_FILES and marks CUDA-only TIRX tests with requires_cuda, so CPU CI can run the full directory while skipping CUDA-only cases. It also adds compute capability guards for Hopper/Blackwell/TMA/TCGEN-specific tests to avoid running them on unsupported GPU architectures.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables CUDA testing for the tirx component by adding pytest marks and compute version requirements across multiple test files, and including tirx in the unit test execution script. The feedback provided identifies several opportunities to improve the precision of these guards, specifically by applying module-level compute version requirements for architecture-specific features like Hopper (SM 90) and Blackwell (SM 100), and correcting the version argument format for SM 7.5.

Comment thread tests/python/tirx/codegen/test_codegen_cuda.py
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_gemm_async.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_copy_async_tmem.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_smem_tmem_dispatch.py Outdated
Comment thread tests/python/tirx/codegen/test_codegen_dsmem.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_copy_dsmem.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_copy_async_tma.py Outdated
@tlopex
Copy link
Copy Markdown
Member Author

tlopex commented May 25, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors CUDA compute version requirements in the TVM testing utility by introducing requires_cuda_compute_version_marks and updating the requires_cuda_compute_version decorator. These changes are applied across numerous TIR-X test files to enforce CUDA requirements at the module level using pytestmark. Additionally, the tirx test suite is now included in the unit test execution script. The review feedback correctly identifies several instances where function-level decorators have become redundant due to the new module-level marks and should be removed to improve code maintainability.

Comment thread tests/python/tirx/codegen/test_codegen_hopper.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_copy_async_tma.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_smem_tmem_dispatch.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/test_smem_tmem_dispatch.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant