[BugFix][Vulkan][CodeGen] Change OpControlBarrier to AcquireRelease#19608
Closed
kistenklaus wants to merge 1 commit into
Closed
[BugFix][Vulkan][CodeGen] Change OpControlBarrier to AcquireRelease#19608kistenklaus wants to merge 1 commit into
kistenklaus wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Vulkan SPIR-V code generator to use spv::MemorySemanticsAcquireReleaseMask instead of spv::MemorySemanticsSequentiallyConsistentMask for memory semantics during storage synchronization. There are no review comments to address, and I have no additional feedback to provide.
tqchen
approved these changes
May 25, 2026
kistenklaus
changed the title
Member
|
@tvm-bot rerun |
Member
|
seems some ci issue, would be good to reopen a new pr with the same change to land it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18915
Vulkan codegen previously generated sequentially constistant OpControlBarrier SPIR-V instructions, which is invalid for Vulkan, where we would expect AcquireRelease.