[ZEPPELIN-6670] Add Shared Notebook Core mount contract - #5469
Merged
tbonelee merged 1 commit intoSep 13, 2026
Conversation
voidmatcha
force-pushed
the
ZEPPELIN-6670-shared-core-contract
branch
3 times, most recently
from
September 13, 2026 05:26
4c2ba44 to
0cce93b
Compare
voidmatcha
force-pushed
the
ZEPPELIN-6670-shared-core-contract
branch
from
September 13, 2026 07:57
0cce93b to
32f9efe
Compare
tbonelee
approved these changes
Sep 13, 2026
Contributor
|
Merged into master |
tbonelee
pushed a commit
that referenced
this pull request
Sep 13, 2026
…dencies ### What is this PR for? Fix CI failure introduced by #5469 (already merged as 788d45a). Its `findReactNotebookConsumerViolations` scan restricted recursion to `consumers.has(target)`, but a consumer's own dependency (e.g. a helper file) is never itself added to `consumers`, so the scan stopped detecting forbidden transport imports reached through it. Reverts to the original unconditional recursion. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? ### How should this be tested? `npm run test:notebook-core`: the 3 previously-failing cases (`helper`/`javascript`/`require-outside`) now pass. ### Screenshots (if appropriate) N/A ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5478 from voidmatcha/hotfix/import-boundary-consumer-scan. Signed-off-by: ChanHo Lee <chanholee@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add
@zeppelin/notebook-coreas a shared package for the Angular host and React remote.Define common types for the read-only snapshot,
getSnapshot,subscribe, and mount props. Add dependency-boundary checks and connect the package build, typecheck, and unit tests to the existing Maven/CI lifecycle.This change does not implement the Core runtime. Separate-build object identity and notebook route integration will be verified in ZEPPELIN-6674 and ZEPPELIN-6675.
What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-6670
How should this be tested?
The following checks passed locally in
zeppelin-web-angular:npm run test:notebook-core: 103 tests passednpm run typecheck:notebook-core: passednpm run test:shell: 49 tests passednpm run check:notebook-parity-scenarios: 21 tests and the registry check passedScreenshots (if appropriate)
No UI changes
Questions: