test: Add the required unique_key when building a Request without an ID - #1032
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 91.81% 94.99% +3.17%
==========================================
Files 58 58
Lines 5450 5450
==========================================
+ Hits 5004 5177 +173
+ Misses 446 273 -173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI is red on every type-check and unit-test job: https://github.com/apify/apify-client-python/actions/runs/32821686073
Two PRs that each passed CI on their own conflict semantically once merged together:
unique_keya required field onRequestBase.Request(url='https://example.com')to assertupdate_requestrejects a request with no ID.In that order, the
Requestconstructor now raises a pydanticValidationErrorfor the missinguniqueKeybeforeupdate_requestis ever reached — sotyreported 2missing-argumentdiagnostics and both tests failed on the wrong exception.Supplying the now-required
unique_keymakes the tests exercise what they were written for (the missing ID), not model validation.✍️ Drafted by Claude Code