Skip to content

test: Add the required unique_key when building a Request without an ID - #1032

Merged
vdusek merged 1 commit into
masterfrom
test/request-unique-key
Aug 25, 2026
Merged

vdusek merged 1 commit into
masterfrom
test/request-unique-key

Conversation

@vdusek

@vdusek vdusek commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Master CI is red on every type-check and unit-test job: https://github.com/apify/apify-client-python/actions/runs/32821686073

Two PRs that each passed CI on their own conflict semantically once merged together:

In that order, the Request constructor now raises a pydantic ValidationError for the missing uniqueKey before update_request is ever reached — so ty reported 2 missing-argument diagnostics and both tests failed on the wrong exception.

Supplying the now-required unique_key makes the tests exercise what they were written for (the missing ID), not model validation.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 25, 2026
@vdusek vdusek self-assigned this Aug 25, 2026
@github-actions github-actions Bot added this to the 148th sprint - Tooling team milestone Aug 25, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (3e333a0) to head (197e784).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   91.81%   94.99%   +3.17%     
==========================================
  Files          58       58              
  Lines        5450     5450              
==========================================
+ Hits         5004     5177     +173     
+ Misses        446      273     -173     
Flag Coverage Δ
integration 91.70% <ø> (-0.12%) ⬇️
unit 86.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review August 25, 2026 07:50
@vdusek
vdusek merged commit f1d5a06 into master Aug 25, 2026
30 checks passed
@vdusek
vdusek deleted the test/request-unique-key branch August 25, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants